D19836: Add TeamdriveModifyJob and update teamdrive example to allow renaming a Team Drive.

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> teamdrivecreatejobtest.cpp:2
>  /*
> - * Createright (C) 2019  David Barchiesi <david at barchie.si>
>   *

Oh. I love this! :D

> teamdrivedeletejobtest.cpp:2
>  /*
> - * Deleteright (C) 2019  David Barchiesi <david at barchie.si>
>   *

I love this one even more! :D

> teamdrivemodifyjob.cpp:107
> +        setErrorString(tr("Invalid response content type"));
> +        emitFinished();
> +    }

You should `return` here after calling `emitFinished()`: processing another item after emitting result can lead to some weird states and behavior.

REPOSITORY
  R477 KGAPI Library

REVISION DETAIL
  https://phabricator.kde.org/D19836

To: barchiesi, dvratil
Cc: kde-pim, #libkgapi, barchiesi, gennad, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190317/ae950e8a/attachment.html>