D19487: Akonadi: fix dangling transaction after itemsync failure

David Faure noreply at phabricator.kde.org
Wed Mar 13 23:59:38 GMT 2019


dfaure added a comment.


  The result() signal from TransactionSequence is supposed to be emitted when the TransactionCommitJob or the TransactionRollbackJob finishes, see commitResult() and rollbackResult() further up in the file.
  
  So this emitResult() was wrong and redundant -- see the beginning of this commit log.
  
  In the case of rollback-from-user, we now (in D19488 <https://phabricator.kde.org/D19488>) kill all other subjobs, finish the running one, then run the rollbackjob, then emit result.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D19487

To: dfaure, dvratil, vkrause
Cc: kfunk, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190313/55ea9b06/attachment.html>


More information about the kde-pim mailing list