D20040: Don't finish collection sync task too early

[Milian Wolff]

mwolff created this revision.
mwolff added reviewers: dvratil, dfaure.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
mwolff requested review of this revision.

REVISION SUMMARY
  Only finish tasks in Akonadi::ResourceBasePrivate::changeProcessed
  when it is of type ChangeReply. Otherwise, we may end up removing
  an unrelated task, such as collection syncing, which then leads
  to assertions later on.
  
  BUG: 403642

TEST PLAN
  `akonadictl restart` regularly asserts on me without this
  patch. With this patch, it seems to work - but I have zero clue about
  the possible side-effects I may be introducing here. See the bug
  report for more details from my tracing endavour.

REPOSITORY
  R165 Akonadi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20040

AFFECTED FILES
  src/agentbase/resourcebase.cpp

To: mwolff, dvratil, dfaure
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190325/a1c1e588/attachment.html>