D19632: Port Item to AttributeStorage, so ItemModifyJob doesn't send unmodified attributes.

David Faure noreply at phabricator.kde.org
Sat Mar 9 09:17:40 GMT 2019


dfaure created this revision.
dfaure added a reviewer: dvratil.
Herald added a project: KDE PIM.
dfaure requested review of this revision.

REVISION SUMMARY
  This required moving Attributes into ItemChangeLog, which now hosts
  the AttributeStorage instance for the item. Since the separation of
  ItemChangeLog was made to reduce memory consumption, I hope most items
  don't have any attribute, otherwise this is a bad choice.

TEST PLAN
  unit tests pass

REPOSITORY
  R165 Akonadi

BRANCH
  port_item_to_attribute_storage

REVISION DETAIL
  https://phabricator.kde.org/D19632

AFFECTED FILES
  autotests/libs/itemstoretest.cpp
  autotests/libs/itemstoretest.h
  src/core/item.cpp
  src/core/item_p.h
  src/core/itemchangelog.cpp
  src/core/itemchangelog_p.h
  src/core/jobs/itemmodifyjob.cpp

To: dfaure, dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190309/8a268703/attachment.html>


More information about the kde-pim mailing list