D19982: Make akonadi applications non bundle for macOS

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:13
> +if (APPLE)
> +  ecm_mark_nongui_executable(akonadi_agent_server)
> +endif()

I wonder if it wouldn't be simpler, instead of these three lines, to just write

  set_target_properties(akonadi_agent_server PROPERTIES MACOSX_BUNDLE FALSE)

This is more standard CMake, and doesn't need an ugly if().

ecm_mark_nongui_executable only has value in the fact that it encapsulates Mac and Windows. If it's mac only, then I wouldn't use it.

> CMakeLists.txt:19
>  ecm_mark_nongui_executable(akonadictl)
> +set_target_properties(akonadictl PROPERTIES OUTPUT_NAME akonadictl)
>  target_link_libraries(akonadictl

order matters? or is this a no-op change?

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D19982

To: fazevedo, dvratil, dfaure
Cc: vonreth, dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190325/77e31dd7/attachment.html>