D19742: jobtest: add test for killing a subjob
David Faure
noreply at phabricator.kde.org
Wed Mar 13 23:25:35 GMT 2019
dfaure created this revision.
dfaure added a reviewer: dvratil.
Herald added a project: KDE PIM.
dfaure requested review of this revision.
REVISION SUMMARY
- it turns out that the whole job gets terminated
- after changing FakeSession to delay reconnect like Session,
the unittest actually makes more sense (no more comment about signal not
received because emitted from the constructor)
- call socketDisconnected like Session ends up doing
The main point was to debug a crash I was having in TransactionSequence
when killing subjobs in rollback(). The take away is that disconnecting
from slotResult is a horrible idea, it means mCurrentSubJob stays
dangling and later lostConnection() crashes. Disconnecting is currently
only done for non-running jobs, but too much code sharing brought me into
that bug :)
REPOSITORY
R165 Akonadi
BRANCH
jobtest
REVISION DETAIL
https://phabricator.kde.org/D19742
AFFECTED FILES
autotests/libs/fakesession.cpp
autotests/libs/jobtest.cpp
To: dfaure, dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190313/43b8bdaf/attachment.html>
More information about the kde-pim
mailing list