D19403: Add Team Drive model and basic fetch.

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Awesome, thanks a lot for fixing it! You missed few comments in the `TeamdriveFetchJob`, please fix those too.

INLINE COMMENTS

> teamdrivefetchjob.cpp:51
> +
> +    int maxResults;
> +    bool useDomainAdminAccess;

Initialize to 0 here instead of in ctor, same for `useDomainAdminAccess` below.

> teamdrivefetchjob.cpp:90
> +
> +TeamdriveFetchJob::~TeamdriveFetchJob()
> +{

` = default`

> teamdrivefetchjob.h:84
> +    class Private;
> +    Private *const d;
> +    friend class Private;

`QScopedPointer`

REVISION DETAIL
  https://phabricator.kde.org/D19403

To: barchiesi, dvratil
Cc: kde-pim, #libkgapi, barchiesi, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190304/3f3890a8/attachment.html>