D19487: Akonadi: fix dangling transaction after itemsync failure

David Faure noreply at phabricator.kde.org
Sun Mar 3 20:21:46 GMT 2019


dfaure added a comment.


  I'm not sure, not enough experience with this code for re-architecturing it, I only spent hours debugging one scenario :-)
  
  To me KJob isn't unexpected magic but I agree that here the handling of the jobs seems to be partly in ItemSync and partly in ItemSync, which gets confusing.
  
  But IMHO what would help even more with this code would be for it to be unittested....

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D19487

To: dfaure, dvratil, vkrause
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190303/07e6220b/attachment.html>


More information about the kde-pim mailing list