D19559: Move management of QWebEngineProfile to WebEnginePage, to avoid crash on KMail exit or viewer window close

[Jonathan Marten]

marten updated this revision to Diff 53415.
marten retitled this revision from "Reassign ownership of QWebEngineProfile in MailWebEnginePage, to avoid crash on KMail exit or viewer window close" to "Move management of QWebEngineProfile to WebEnginePage, to avoid crash on KMail exit or viewer window close".
marten edited the test plan for this revision.
marten added a comment.


  Setup and destruction of the QWebEngineProfile moved to WebEnginePage, so MailWebEngineView need know nothing about the profile and MailWebEnginePage only needs to access it via profile().
  
  Akregator currently constructs  a WebEnginePage using its own profile, which however is always the default profile.  This works, because all web views with Akregator use the same browser settings, but changing Akregator and eliminating the 2-argument WebEnginePage constructor would mean that releases of Akregator and messagelib would have to be synchronised exactly.  For the moment I've just marked the 2-argument constructor as deprecated, and Akregator can be updated at a later date.

REPOSITORY
  R94 PIM: Message Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19559?vs=53357&id=53415

REVISION DETAIL
  https://phabricator.kde.org/D19559

AFFECTED FILES
  messageviewer/src/viewer/webengine/mailwebenginepage.cpp
  messageviewer/src/viewer/webengine/mailwebenginepage.h
  messageviewer/src/viewer/webengine/mailwebengineview.cpp
  webengineviewer/src/webenginepage.cpp
  webengineviewer/src/webenginepage.h

To: marten, #kde_pim, dvratil
Cc: anthonyfieroni, dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190308/cca96890/attachment.html>