D19830: Force build order to prevent build happening before ui .h file exists

[Pino Toscano]

pino added a comment.


  It's a simple race condition between two targets:
  
  - ui_alarmtyperadiowidget.h is included by ../shared/alarmtyperadiowidget.cpp
  - ui_alarmtyperadiowidget.h is built only as part of the akonadi_kalarm_resource target
  - both the akonadi_kalarm_resource, and kalarmconfig targets have ../shared/alarmtyperadiowidget.cpp as source
  
  hence, if ui_alarmtyperadiowidget.h is not generated before the build of the kalarmconfig starts, then the error happens
  
  IMHO this patch does not fix the issue, because nothing will make the build of the kalarmconfig target wait for the generated ui_alarmtyperadiowidget.h.
  
  A simpler solution is to make the kalarmconfig target depend on the akonadi_kalarm_resource one:
  
    add_dependencies(kalarmconfig akonadi_kalarm_resource)

REPOSITORY
  R44 KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D19830

To: jriddell, mlaurent, #kde_pim, cgiboudeaux
Cc: pino, dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190318/ecc97cd5/attachment.html>