D19739: Make the feed uri the baseUrl for previews

Laurent Montel noreply at phabricator.kde.org
Thu Mar 14 08:12:53 GMT 2019


mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> articleviewerwidget.cpp:196
>  
> +    m_articleHtmlWriter->setBaseUrl(QUrl(article.feed()->xmlUrl()));
>      m_viewMode = NormalView;

Are you sure that article.feed()->xmlUrl() is never null ?

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D19739

To: pinaraf, #kde_pim, mlaurent
Cc: mlaurent, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190314/5a23eb10/attachment.html>


More information about the kde-pim mailing list