D22161: Move attachment temporary file handling from Incidence to Attachment
Volker Krause
noreply at phabricator.kde.org
Sun Jun 30 14:02:22 BST 2019
vkrause abandoned this revision.
vkrause added a comment.
In D22161#488303 <https://phabricator.kde.org/D22161#488303>, @pino wrote:
> What about instead not add any temporary file handling to Attachment?
>
> After all, `writeAttachmentToTempFile()` seems to be used only in two places (both in calendarsupport):
>
> 1. src/incidenceattachmentmodel.cpp
> 2. src/utils.cpp At least (2) looks easy enough to port away: in non-uri attachments, create the destination file, and write `data()` directly to it (without KIO).
It's actually even easier, none of the code using this actually seems to be used... Thanks for noticing, I'll remove this altogether then.
REPOSITORY
R172 KCalendar Core
REVISION DETAIL
https://phabricator.kde.org/D22161
To: vkrause
Cc: pino, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190630/0a17bf71/attachment.html>
More information about the kde-pim
mailing list