D21714: Raise limit for PimItem.remoteId to 1024 characters

Daniel Vrátil noreply at phabricator.kde.org
Mon Jun 10 10:09:34 BST 2019


dvratil created this revision.
dvratil added a reviewer: KDE PIM.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
dvratil requested review of this revision.

REVISION SUMMARY
  Some DAV servers produce exteremely long RIDs that do not fit into the
  current 255 character limit. This is only problem on MySQL, on other
  DBs we use TEXT, which has no length limit.
  
  On MySQL, just increasing the column length to 1024 is not enough,
  there's a limit on maximum length of VARBINARY/VARCHAR index, which is
  756 bytes (255 characters). To be able to have an index on a VARBINARY
  column with up to 1024 characters we need to enable innodb_large_prefix
  and change how the extra characters are stored on the disk (ROW_FORMAT).

TEST PLAN
  Modified a unit-test to attempt creating an Item with 1024 characters long RID

REPOSITORY
  R165 Akonadi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21714

AFFECTED FILES
  autotests/libs/itemappendtest.cpp
  src/server/storage/akonadidb.xml
  src/server/storage/dbinitializer_p.cpp
  src/server/storage/dbupdate.xml
  src/server/storage/mysql-global-mobile.conf

To: dvratil, #kde_pim
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190610/fcb8faab/attachment.html>


More information about the kde-pim mailing list