D22828: Fix failures in autotest templateparserjobtest

Glen Ditchfield noreply at phabricator.kde.org
Tue Jul 30 14:54:29 BST 2019


gjditchfield created this revision.
gjditchfield added a reviewer: knauss.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
gjditchfield requested review of this revision.

REVISION SUMMARY
  templateparserjobtest suffers 3 failures in test_replyHtml() at lines
  
    QVERIFY(parser->d->mOtp->htmlContent().isEmpty());
    QVERIFY(!parser->d->mOtp->plainTextContent().isEmpty());
  
  I think these lines were added accidentally.
  
  - If I understand the git history, they were added in revision a13359849ef0 <https://phabricator.kde.org/R94:a13359849ef0c9a8fbcc01234350d74ccbc2bc64>, "Merge branch 'Applications/19.04'", but they don't exist on the 19.04 branch or the previous master revision.
  - The first line verifies that htmlContent is empty, but later the test checks for expected HTML content.
  - test_replyHtml() has similar structure to test_replyPlain(), test_forwardplain(), and test_forwardHtml(), which do not have similar tests.
  
  This patch deletes the lines.

REPOSITORY
  R94 PIM: Message Library

BRANCH
  templateparserjobtest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22828

AFFECTED FILES
  templateparser/autotests/templateparserjobtest.cpp

To: gjditchfield, knauss
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190730/a58920df/attachment.html>


More information about the kde-pim mailing list