D22697: Rename the KCalCore namespace to KCalendarCore

David Faure noreply at phabricator.kde.org
Wed Jul 24 22:28:22 BST 2019


dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> CMakeLists.txt:50
> +# TODO: remove for KF6
> +target_compile_definitions(KF5CalendarCore PUBLIC "-DKCalCore=KCalendarCore")
>  target_include_directories(KF5CalendarCore INTERFACE "$<INSTALL_INTERFACE:${KDE_INSTALL_INCLUDEDIR_KF5}/KCalCore>")

This could be INTERFACE rather than PUBLIC, we don't need this define when compiling KF5CalendarCore itself (assuming there's no KCalCore left in there).

REPOSITORY
  R172 KCalendar Core

BRANCH
  Applications/19.08

REVISION DETAIL
  https://phabricator.kde.org/D22697

To: vkrause, #kde_pim, dfaure
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190724/188b9bc0/attachment.html>


More information about the kde-pim mailing list