D21391: Turn Person into a value type

Volker Krause noreply at phabricator.kde.org
Tue Jul 23 10:03:27 BST 2019


vkrause added a comment.


  In D21391#500365 <https://phabricator.kde.org/D21391#500365>, @dfaure wrote:
  
  > This change broke calligra:
  >
  >   /d/kde/src/5/calligra/calligra/plan/src/plugins/filters/icalendar/export/icalendarexport.cpp:143:27: error: ‘Ptr’ is not a member of ‘KCalCore::Person’
  >           KCalCore::Person::Ptr p = KCalCore::Person::fromFullName(node->leader());
  >                             ^~~
  
  
  Not sure if I'm looking at the same code (path/line numbers don't match), but https://cgit.kde.org/calligraplan.git/tree/src/plugins/filters/icalendar/export/icalendarexport.cpp already seems to have an #ifdef for this (which would need to be extended to the same change in Attendee though).

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D21391

To: vkrause, mlaurent
Cc: dfaure, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190723/3ecc1625/attachment.html>


More information about the kde-pim mailing list