D22601: i18n: Add context @title:window to window titles

[Pino Toscano]

pino added a comment.


  Since you are changing the strings, I suggest changing them to bein line with the HIG:
  https://hig.kde.org/style/writing/capitalization.html

INLINE COMMENTS

> exportpaperkeycommand.cpp:114
>      QPrintDialog printDialog(&printer, mParent);
> -    printDialog.setWindowTitle(i18nc("@title", "Print secret key"));
> +    printDialog.setWindowTitle(i18nc("@title:window", "Print secret key"));
>  

"Print Secret Map"

> signencryptemailconflictdialog.cpp:417
>  
> -            q->setWindowTitle(i18n("Select Certificates For Message"));
> +            q->setWindowTitle(i18nc("@title:window", "Select Certificates For Message"));
>  

"for"

> signencryptemailconflictdialog.cpp:542
>  {
> -    setWindowTitle(i18n("Select Certificates For Message \"%1\"", subject));
> +    setWindowTitle(i18nc("@title:window", "Select Certificates For Message \"%1\"", subject));
>  }

"for"

> exportdialog.cpp:172
>      }
> -    setWindowTitle(i18n("Export..."));
> +    setWindowTitle(i18nc("@title:window", "Export..."));
>  

no "..."

> subkeyswidget.cpp:173
>  {
> -    setWindowTitle(i18n("Subkeys details"));
> +    setWindowTitle(i18nc("@title:window", "Subkeys details"));
>      auto l = new QVBoxLayout(this);

"Details"

> updatenotification.cpp:214
>      label->setWordWrap(true);
> -    setWindowTitle(i18n("Update available!"));
> +    setWindowTitle(i18nc("@title:window", "Update available!"));
>      setWindowIcon(QIcon(QLatin1String("gpg4win")));

"Update Available" (no exclamation mark)

> pgpcardwidget.cpp:278
>      progress->setCancelButton(nullptr);
> -    progress->setWindowTitle(i18n("Generating keys"));
> +    progress->setWindowTitle(i18nc("@title:window", "Generating keys"));
>      progress->setLabel(new QLabel(i18n("This may take several minutes...")));

"Keys"

REPOSITORY
  R168 Kleopatra

REVISION DETAIL
  https://phabricator.kde.org/D22601

To: aspotashev
Cc: pino, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190721/0ede0844/attachment.html>