D22300: Use QTWEBENGINE_VERSION not QT_VERSION for WebEngine feature detection
Wolfgang Bauer
noreply at phabricator.kde.org
Sat Jul 6 23:29:49 BST 2019
wbauer added a comment.
This doesn't work as intended (at least here on openSUSE).
I just built it with QtWebEngine 5.13(.0), and it incorrectly took the < 5.13.0 branch.
AFAICT, you need to `#include <QtWebEngine/QtWebEngineVersion>` so that QTWEBENGINE_VERSION is actually defined...
But as `QWebEngineProfile` is actually part of QtWebEngineWidgets, it would probably be more correct to test QTWEBENGINEWIDGETS_VERSION instead (and `#include <QtWebEngineWidgetsVersion>`).
REPOSITORY
R94 PIM: Message Library
REVISION DETAIL
https://phabricator.kde.org/D22300
To: tcberner, #automotive, mlaurent, vkrause
Cc: wbauer, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190706/173468fc/attachment.html>
More information about the kde-pim
mailing list