D22246: Adapt to KCalCore::Attachment changes
Daniel Vrátil
noreply at phabricator.kde.org
Wed Jul 3 20:25:55 BST 2019
dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> attachmenthandler.cpp:84
> +Attachment AttachmentHandler::find(const QString &attachmentName,
> const Incidence::Ptr &incidence)
> {
Indentation
> attachmenthandler.cpp:127
> +Attachment AttachmentHandler::find(const QString &attachmentName,
> const ScheduleMessage::Ptr &message)
> {
Indentation
> attachmenthandler.h:66
> + KCalCore::Attachment find(const QString &attachmentName,
> const KCalCore::Incidence::Ptr &incidence);
>
Fix indentation (below as well)
> incidenceattachmentmodel.cpp:191
>
> - KCalCore::Attachment::Ptr attachment = d->m_incidence->attachments().at(index.row());
> + KCalCore::Attachment attachment = d->m_incidence->attachments().at(index.row());
> switch (role) {
Make it `const`
REPOSITORY
R75 PIM: Calendar Support
REVISION DETAIL
https://phabricator.kde.org/D22246
To: vkrause, dvratil
Cc: dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190703/de488141/attachment-0001.html>
More information about the kde-pim
mailing list