D17947: Export the APIs needed to build Blogilo again

Kevin Kofler noreply at phabricator.kde.org
Thu Jan 3 18:57:29 GMT 2019


kkofler created this revision.
kkofler added reviewers: KDE PIM, mlaurent.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
kkofler requested review of this revision.

REVISION SUMMARY
  This undoes parts of Laurent Montel's export cleanups, because those 4
  classes are needed to build (the last release of) Blogilo:
  
  - src/CMakeLists.txt: Install the InsertHtmlDialog headers (inserthtmldialog.h, InsertHtmlDialog).
  
  - src/emoticontexteditaction.h: Export the KPIMTextEdit::EmoticonTextEditAction class.
  
  - src/inserthtmldialog.h: Use the public export macros for the KPIMTextEdit::InsertHtmlDialog class.
  
  - src/insertimagewidget.h: Export the KPIMTextEdit::InsertImageWidget class.
  
  - src/inserttablewidget.h: Export the KPIMTextEdit::InsertTableWidget class.
  
  This allows building Blogilo again.

TEST PLAN
  I verified that this gets Blogilo building again:
  https://copr.fedorainfracloud.org/coprs/kkofler/kannolo/build/841423/
  https://copr.fedorainfracloud.org/coprs/kkofler/kannolo/build/841425/
  
  (You also need this upstream patch for Blogilo that did not make the last release: https://cgit.kde.org/blogilo.git/commit/?id=0ad74f6ca737e547c2181be11e00d2703db63616 )

REPOSITORY
  R86 PIM: Text Editor

REVISION DETAIL
  https://phabricator.kde.org/D17947

AFFECTED FILES
  src/CMakeLists.txt
  src/emoticontexteditaction.h
  src/inserthtmldialog.h
  src/insertimagewidget.h
  src/inserttablewidget.h

To: kkofler, #kde_pim, mlaurent
Cc: rdieter, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190103/d20f0055/attachment.html>


More information about the kde-pim mailing list