D18709: Fix tag change notification shipping a bogus name.

David Faure noreply at phabricator.kde.org
Sun Feb 3 19:09:26 GMT 2019


dfaure created this revision.
dfaure added a reviewer: dvratil.
dfaure requested review of this revision.

REVISION SUMMARY
  The code doing a SQL query was preparing a condition, but wasn't
  actually using it. So this was listing all attributes from
  ALL tags (instead of the desired one) and the last one would win.
  
  Bug initially detected by zanshin's unittests.

TEST PLAN
  Added a new unittest in tagtest which failed before this fix
  (the notification contained the name of the second tag)

BRANCH
  2019_01_aggregatedfetchscope_test

REVISION DETAIL
  https://phabricator.kde.org/D18709

AFFECTED FILES
  autotests/libs/tagtest.cpp
  src/server/handlerhelper.cpp

To: dfaure, dvratil
Cc: ervin, kde-pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190203/35394667/attachment.html>


More information about the kde-pim mailing list