D18695: AggregatedFetchScope: fix fetchAllAttributes for tags.

David Faure noreply at phabricator.kde.org
Sun Feb 3 14:22:36 GMT 2019


dfaure created this revision.
dfaure added a reviewer: dvratil.
dfaure requested review of this revision.

REVISION SUMMARY
  This is a third case for aggregation: the default is *true*,
  so any subscriber with default settings was NOT calling
  AggregatedTagFetchScope::setFetchAllAttributes, so
  d->fetchAllAttributes > 0 was false, unexpectedly.
  
  Count the number of subscribers who call with false, and return
  false only if all of them agree with that.

TEST PLAN
  tagtest

BRANCH
  2019_01_aggregatedfetchscope_test

REVISION DETAIL
  https://phabricator.kde.org/D18695

AFFECTED FILES
  autotests/server/notificationmanagertest.cpp
  src/server/aggregatedfetchscope.cpp

To: dfaure, dvratil
Cc: kde-pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190203/a177af86/attachment.html>


More information about the kde-pim mailing list