D19189: [KMail] Add an option to start in tray

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> configureappearancepage.cpp:889
> +    // Dependencies between the two checkboxes
> +    connect(mStartInTrayCheck, &QCheckBox::stateChanged, this, [this](int state) {
> +      if (state == Qt::Checked)

Please merge two signal :
connect(mStartInTrayCheck, &QCheckBox::stateChanged,

  this, &ConfigModuleTab::slotEmitChanged);

and this one in one slot.
Not necessary to have 2 connections

> configureappearancepage.cpp:893
> +    });
> +    connect(mSystemTrayCheck, &QCheckBox::stateChanged, this, [this](int state) {
> +      if(state == Qt::Unchecked)

same

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D19189

To: matthieugras, #kde_pim_kmail, mlaurent
Cc: dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190221/50d5f53e/attachment.html>