D18711: Simplify AggregatedFetchScope code, removing all setters.

David Faure noreply at phabricator.kde.org
Sun Feb 3 19:45:51 GMT 2019


dfaure created this revision.
dfaure added a reviewer: dvratil.
dfaure requested review of this revision.

REVISION SUMMARY
  The naming was confusing (those were not setters but a counter
  increase/decrease -- if you call a setter with the same value twice, you
  expect the second call to be a no-op), and they were used from a single
  place anyway.
  
  Also remove unused methods (add/remove).

TEST PLAN
  notificationmanagertest and aggregatedfetchscopetest still pass

BRANCH
  2019_01_aggregatedfetchscope_test

REVISION DETAIL
  https://phabricator.kde.org/D18711

AFFECTED FILES
  src/server/aggregatedfetchscope.cpp
  src/server/aggregatedfetchscope.h

To: dfaure, dvratil
Cc: kde-pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190203/36e37cd6/attachment.html>


More information about the kde-pim mailing list