D26257: Add extractors for Kintetsu Railway Limited Express reservations

Volker Krause noreply at phabricator.kde.org
Sat Dec 28 15:24:18 GMT 2019


vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.


  Thanks! Test data is always a good idea to prevent this breaking on engine changes. For plain text it might even be possible to create a synthetic one to add to the extractor tests in this repo, but that's not a blocker.

INLINE COMMENTS

> kintetsu.js:34
> +    if (Context.data)
> +        return null; // this is just backup if we have no structured data
> +    var res = JsonLd.newTrainReservation();

Those two lines should not be needed.

REPOSITORY
  R1003 KItinerary: Travel Reservation handling library

BRANCH
  kintetsu-extractor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26257

To: lbeltrame, vkrause
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20191228/520d0f7c/attachment.html>


More information about the kde-pim mailing list