D23045: Don't leave dangling pointers in AlarmCalendar when removeKAEvents doesn't remove the whole collection

Jiří Paleček noreply at phabricator.kde.org
Fri Aug 9 14:45:11 BST 2019


jpalecek created this revision.
jpalecek added a reviewer: djarvie.
Herald added a project: KDE PIM.
jpalecek requested review of this revision.

REVISION SUMMARY
  AlarmCalendar::removeKAEvents can sometimes delete some, but not all
   events from a KAEvent::List stored in mResourceMap. In that case, the
   list is left as is, with some pointers invalid. That would later
   cause crashes.
  
  This patch only retains valid pointer in the collection.
  
  BUG: 410596

REPOSITORY
  R205 KAlarm

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23045

AFFECTED FILES
  src/alarmcalendar.cpp

To: jpalecek, djarvie
Cc: kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190809/98008907/attachment.html>


More information about the kde-pim mailing list