D19948: DRAFT Add Standard Query Parameters support

Thu Apr 25 01:17:40 BST 2019

barchiesi updated this revision to Diff 56936.
barchiesi added a comment.

  So I ditched Job::authorizedRequest() and now apply auth headers and standard params directly in Job::Private::_k_dispatchTimeout(). Basically I realized that perhaps some kind of jobs don't need the prettyPrint param set to false (no output or the cost is greater than the gain? delete methods maybe?) and in these cases I want to be able to remove the query param in the dispatchRequest implementation (eg. DeleteJob::dispatchRequest).
  Does the above seem reasonable?
  I also fixed up a little FileLogger so it produces a cleaner output.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19948?vs=56900&id=56936

BRANCH
  wip

REVISION DETAIL
  https://phabricator.kde.org/D19948

AFFECTED FILES
  autotests/calendar/data/calendar1_create_request.txt
  autotests/calendar/data/calendar1_delete_request.txt
  autotests/calendar/data/calendar1_fetch_request.txt
  autotests/calendar/data/calendar1_modify_request.txt
  autotests/calendar/data/calendar2_create_request.txt
  autotests/calendar/data/calendar2_delete_request.txt
  autotests/calendar/data/calendar2_modify_request.txt
  autotests/calendar/data/calendars_fetch_page1_request.txt
  autotests/calendar/data/calendars_fetch_page2_request.txt
  autotests/calendar/data/event1_create_request.txt
  autotests/calendar/data/event1_delete_request.txt
  autotests/calendar/data/event1_fetch_request.txt
  autotests/calendar/data/event1_modify_request.txt
  autotests/calendar/data/event2_create_request.txt
  autotests/calendar/data/event2_delete_request.txt
  autotests/calendar/data/event2_modify_request.txt
  autotests/calendar/data/events_fetch_page1_request.txt
  autotests/calendar/data/events_fetch_page2_request.txt
  autotests/calendar/data/freebusy1_query_request.txt
  autotests/contacts/data/contact1_create_request.txt
  autotests/contacts/data/contact1_delete_photo_request.txt
  autotests/contacts/data/contact1_delete_request.txt
  autotests/contacts/data/contact1_fetch_photo_request.txt
  autotests/contacts/data/contact1_fetch_request.txt
  autotests/contacts/data/contact1_modify_request.txt
  autotests/contacts/data/contact2_create_photo_request.txt
  autotests/contacts/data/contact2_create_request.txt
  autotests/contacts/data/contact2_delete_request.txt
  autotests/contacts/data/contact2_fetch_photo_request.txt
  autotests/contacts/data/contact2_modify_request.txt
  autotests/contacts/data/contacts_fetch_page1_request.txt
  autotests/contacts/data/contacts_fetch_page2_request.txt
  autotests/contacts/data/contacts_group1_create_request.txt
  autotests/contacts/data/contacts_group1_delete_request.txt
  autotests/contacts/data/contacts_group1_fetch_request.txt
  autotests/contacts/data/contacts_group1_modify_request.txt
  autotests/contacts/data/contacts_group2_create_request.txt
  autotests/contacts/data/contacts_group2_delete_request.txt
  autotests/contacts/data/contacts_group2_modify_request.txt
  autotests/contacts/data/contacts_groups_fetch_page1_request.txt
  autotests/contacts/data/contacts_groups_fetch_page2_request.txt
  autotests/core/createjobtest.cpp
  autotests/core/data/accountinfo_fetch_request.txt
  autotests/core/data/accountmanager_part1_request.txt
  autotests/core/data/accountmanager_refresh_request.txt
  autotests/core/fetchjobtest.cpp
  autotests/drive/aboutfetchjobtest.cpp
  autotests/drive/data/about_fetch_limited_fields_request.txt
  autotests/drive/data/about_fetch_limited_fields_response.txt
  autotests/drive/data/about_fetch_request.txt
  autotests/drive/data/about_limited_fields.json
  autotests/drive/data/change1_fetch_request.txt
  autotests/drive/data/changes_fetch_page1_request.txt
  autotests/drive/data/changes_fetch_page2_request.txt
  autotests/drive/data/file1_copy_request.txt
  autotests/drive/data/file1_create_request.txt
  autotests/drive/data/file2_copy_request.txt
  autotests/drive/data/file2_create_request.txt
  autotests/drive/data/teamdrive_create_request.txt
  autotests/drive/data/teamdrive_delete_request.txt
  autotests/drive/data/teamdrive_fetch_request.txt
  autotests/drive/data/teamdrive_modify_request.txt
  autotests/tasks/data/task1_create_request.txt
  autotests/tasks/data/task1_delete_request.txt
  autotests/tasks/data/task1_fetch_request.txt
  autotests/tasks/data/task1_modify_request.txt
  autotests/tasks/data/task1_move_request.txt
  autotests/tasks/data/task2_create_request.txt
  autotests/tasks/data/task2_delete_request.txt
  autotests/tasks/data/task2_modify_request.txt
  autotests/tasks/data/task2_move_request.txt
  autotests/tasks/data/task2_move_with_parent_request.txt
  autotests/tasks/data/tasklist1_create_request.txt
  autotests/tasks/data/tasklist1_delete_request.txt
  autotests/tasks/data/tasklist1_modify_request.txt
  autotests/tasks/data/tasklist2_create_request.txt
  autotests/tasks/data/tasklist2_delete_request.txt
  autotests/tasks/data/tasklist2_modify_request.txt
  autotests/tasks/data/tasklists_fetch_page1_request.txt
  autotests/tasks/data/tasklists_fetch_page2_request.txt
  autotests/tasks/data/tasks_fetch_page1_request.txt
  autotests/tasks/data/tasks_fetch_page2_request.txt
  examples/teamdrive/mainwindow.cpp
  src/blogger/blogfetchjob.cpp
  src/blogger/commentdeletejob.cpp
  src/blogger/commentfetchjob.cpp
  src/blogger/pagecreatejob.cpp
  src/blogger/pagedeletejob.cpp
  src/blogger/pagefetchjob.cpp
  src/blogger/pagemodifyjob.cpp
  src/blogger/postcreatejob.cpp
  src/blogger/postdeletejob.cpp
  src/blogger/postfetchjob.cpp
  src/blogger/postmodifyjob.cpp
  src/blogger/postsearchjob.cpp
  src/calendar/calendarcreatejob.cpp
  src/calendar/calendardeletejob.cpp
  src/calendar/calendarfetchjob.cpp
  src/calendar/calendarmodifyjob.cpp
  src/calendar/eventcreatejob.cpp
  src/calendar/eventdeletejob.cpp
  src/calendar/eventfetchjob.cpp
  src/calendar/eventmodifyjob.cpp
  src/calendar/eventmovejob.cpp
  src/calendar/freebusyqueryjob.cpp
  src/contacts/contactcreatejob.cpp
  src/contacts/contactdeletejob.cpp
  src/contacts/contactfetchjob.cpp
  src/contacts/contactfetchphotojob.cpp
  src/contacts/contactmodifyjob.cpp
  src/contacts/contactsgroupcreatejob.cpp
  src/contacts/contactsgroupdeletejob.cpp
  src/contacts/contactsgroupfetchjob.cpp
  src/contacts/contactsgroupmodifyjob.cpp
  src/core/accountinfo/accountinfofetchjob.cpp
  src/core/job.cpp
  src/core/job.h
  src/core/job_p.h
  src/drive/about.cpp
  src/drive/about.h
  src/drive/aboutfetchjob.cpp
  src/drive/appfetchjob.cpp
  src/drive/changefetchjob.cpp
  src/drive/childreferencecreatejob.cpp
  src/drive/childreferencedeletejob.cpp
  src/drive/childreferencefetchjob.cpp
  src/drive/file.cpp
  src/drive/file.h
  src/drive/fileabstractmodifyjob.cpp
  src/drive/fileabstractuploadjob.cpp
  src/drive/filecopyjob.cpp
  src/drive/filedeletejob.cpp
  src/drive/filefetchcontentjob.cpp
  src/drive/filefetchjob.cpp
  src/drive/filefetchjob.h
  src/drive/parentreferencecreatejob.cpp
  src/drive/parentreferencedeletejob.cpp
  src/drive/parentreferencefetchjob.cpp
  src/drive/permissioncreatejob.cpp
  src/drive/permissiondeletejob.cpp
  src/drive/permissionfetchjob.cpp
  src/drive/permissionmodifyjob.cpp
  src/drive/revisiondeletejob.cpp
  src/drive/revisionfetchjob.cpp
  src/drive/revisionmodifyjob.cpp
  src/drive/teamdrivecreatejob.cpp
  src/drive/teamdrivedeletejob.cpp
  src/drive/teamdrivefetchjob.cpp
  src/drive/teamdrivemodifyjob.cpp
  src/latitude/locationcreatejob.cpp
  src/latitude/locationdeletejob.cpp
  src/latitude/locationfetchhistoryjob.cpp
  src/latitude/locationfetchjob.cpp
  src/tasks/taskcreatejob.cpp
  src/tasks/taskdeletejob.cpp
  src/tasks/taskfetchjob.cpp
  src/tasks/tasklistcreatejob.cpp
  src/tasks/tasklistdeletejob.cpp
  src/tasks/tasklistfetchjob.cpp
  src/tasks/tasklistmodifyjob.cpp
  src/tasks/taskmodifyjob.cpp
  src/tasks/taskmovejob.cpp

To: barchiesi, dvratil
Cc: kde-pim, #libkgapi, barchiesi, gennad, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190425/15ae256d/attachment.html>