D20727: Port Grantlee contact printing model to KContacts::Addressee too

[Daniel Vrátil]

dvratil added inline comments.

INLINE COMMENTS

> grantleeprinttest.cpp:107
>      QTest::newRow("profesion") << QStringLiteral("profession") << QStringLiteral("foo-profession");
> -    QTest::newRow("manager") << QStringLiteral("manager") << QStringLiteral("foo-managersname");
> -    QTest::newRow("assistant") << QStringLiteral("assistant") << QStringLiteral("foo-assistantsname");
> -    QTest::newRow("spouse") << QStringLiteral("spouse") << QStringLiteral("foo-spousesname");
> +    QTest::newRow("manager") << QStringLiteral("managersName") << QStringLiteral("foo-managersname");
> +    QTest::newRow("assistant") << QStringLiteral("assistantsName") << QStringLiteral("foo-assistantsname");

Does this needs adjustments in the printing templates as well?

> grantleeprint.cpp:95
> +    for (const KContacts::Addressee &contact : contacts) {
> +        contactsList.push_back(QVariant::fromValue(*reinterpret_cast<const ContactGrantleeWrapper*>(&contact)));
>      }

The `reinterpret_cast` looks very shady, hopefully, we can get rid of it soon.

REPOSITORY
  R82 KDE PIM Application Libraries

REVISION DETAIL
  https://phabricator.kde.org/D20727

To: vkrause
Cc: dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190428/eeba2268/attachment.html>