D20306: Make Akonadi compile without QT_STRICT_ITERATORS

Daniel Vrátil noreply at phabricator.kde.org
Sat Apr 6 15:08:16 BST 2019


dvratil created this revision.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
dvratil requested review of this revision.

REVISION SUMMARY
  Without QT_STRICT_ITERATORS QVector and QList iterators do not satisfy the
  STL iterator requirements since they are simply just T*. We can work around
  that by introducing a helper to provide the necessary traits for those.
  
  At the same time, turns out QT_STRICT_ITERATORS does not introduce any
  overhead (they are inlined so everything gets optimized), confirmed by
  comparing the produced assembly in Compiler Explorer.

TEST PLAN
  Compiles

REPOSITORY
  R165 Akonadi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20306

AFFECTED FILES
  CMakeLists.txt
  src/shared/akranges.h

To: dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190406/4f39a74c/attachment.html>


More information about the kde-pim mailing list