D19948: DRAFT Add Standard Query Parameters support

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  WOW, this is huge! Big thanks.
  
  I think generally it could go in like it is, but since this review ended up doing three changes, would you mind to split it into three reviews? One for the authorization header, one for the pretty-print and one for the custom fields - mostly to just avoid having one massive git commit touching everything.

INLINE COMMENTS

> about.cpp:364
>  
> +const QString About::Fields::AdditionalRoleInfo= QStringLiteral("additionalRoleInfo");
> +const QString About::Fields::AdditionalRoles= QStringLiteral("additionalRoles");

Coding style: spaces around `=` (here and everywhere below)

REVISION DETAIL
  https://phabricator.kde.org/D19948

To: barchiesi, dvratil
Cc: kde-pim, #libkgapi, barchiesi, gennad, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190428/59a2927c/attachment.html>