D20337: Rollback changes to CollectionReferenceManager on DB rollback

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> collectionstatistics.cpp:215
>  
> -    return qb;
> +    return std::move(qb);
>  }

This should never be needed.
http://eel.is/c++draft/class.copy.elision#3

> akscopeguard.h:35
> +    {
> +        if (mFunc) {
> +            mFunc();

Is there any situation where this might be null?

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D20337

To: dvratil, dfaure
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190407/0b843c74/attachment.html>