D20291: Add unittest for clearPayload. Unfortunately it passes :-)

Daniel Vrátil noreply at phabricator.kde.org
Sat Apr 6 11:14:39 BST 2019


dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> invalidatecachejobtest.cpp:49
> +    // Find collection by name
> +    auto *resolver = new CollectionPathResolver(QStringLiteral("res1/foo"), this);
> +    AKVERIFYEXEC(resolver);

There's synchronous `collectionIdFromPath()` in `test_utils.h` that does this already.

> invalidatecachejobtest.cpp:78
> +    AKVERIFYEXEC(fetchFromCacheJob);
> +    QCOMPARE(fetchFromCacheJob->items().first().payloadData(), "");
> +

Use `isEmpty()` instead.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D20291

To: dfaure, dvratil, vkrause
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190406/f6bcaa30/attachment.html>


More information about the kde-pim mailing list