D20363: CollectionScheduler: port to qint64 to avoid the year-2038 bug

Pino Toscano noreply at phabricator.kde.org
Sun Apr 7 18:30:00 BST 2019


pino added inline comments.

INLINE COMMENTS

> collectionscheduler.cpp:224
>      // cast next - now() to int, so that we get negative result when next is in the past
> -    mScheduler->start(qMax(0, (int)(next - QDateTime::currentDateTimeUtc().toTime_t()) * 1000));
> +    mScheduler->start(qMax(0, (int)(next - QDateTime::currentSecsSinceEpoch()) * 1000));
>  }

isn't this still problematic (i.e. the cast to int)?

REVISION DETAIL
  https://phabricator.kde.org/D20363

To: dfaure, dvratil
Cc: pino, kde-pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190407/893916ac/attachment.html>


More information about the kde-pim mailing list