D15065: Implement Unified Mailboxes agent

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> unifiedmailbox.cpp:126
> +    }
> +    for (auto source : sources) {
> +        addSourceCollection(source);

const'ref ?

> unifiedmailbox.cpp:141
> +            // Force that we start monitoring all the collections
> +            for (auto source : mSources) {
> +                manager->mMonitor.setCollectionMonitored(Akonadi::Collection{source});

const'ref ?

> unifiedmailbox.cpp:146
> +        } else {
> +            for (auto source : mSources) {
> +                mManager->mMonitor.setCollectionMonitored(Akonadi::Collection{source}, false);

same ?

> unifiedmailboxeditor.h:29
> +public:
> +    explicit UnifiedMailboxEditor(KSharedConfigPtr config, QWidget *parent = nullptr);
> +    explicit UnifiedMailboxEditor(UnifiedMailbox *mailbox, KSharedConfigPtr config, QWidget *parent = nullptr);

const'ref

> unifiedmailboxeditor.h:30
> +    explicit UnifiedMailboxEditor(KSharedConfigPtr config, QWidget *parent = nullptr);
> +    explicit UnifiedMailboxEditor(UnifiedMailbox *mailbox, KSharedConfigPtr config, QWidget *parent = nullptr);
> +

const'ref

> unifiedmailboxmanager.cpp:427
> +    if (!box->isSpecial()) {
> +        qDebug() << colId << "does not belong to a special unified box" << box->id();
> +        return {};

qCDebug

> unifiedmailboxmanager.h:46
> +
> +    explicit UnifiedMailboxManager(KSharedConfigPtr config, QObject *parent = nullptr);
> +    ~UnifiedMailboxManager() override;

const'ref

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D15065

To: dvratil, mlaurent
Cc: lueck, ngraham, mlaurent, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180904/589210e9/attachment.html>