D15467: Add open on phone action to Itinerary reservations

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> semanticurlhandler.cpp:286
> +    if(reply.isValid()) {
> +        for (const QString& deviceId : reply.value()) {
> +

coding style "const QString &"

> semanticurlhandler.cpp:459
> +
> +void SemanticUrlHandler::openWithKDEConnect(MimeTreeParser::Interface::BodyPart *part, const QString& deviceId) const
> +{

coding style const QString &

> semanticurlhandler.cpp:500
> +        }
> +        f.write(b);
> +        part->nodeHelper()->addTempFile(f.fileName());

f.close(); after that no ?

> semanticurlhandler.h:47
>      void openInApp(MimeTreeParser::Interface::BodyPart *part) const;
> +    void openWithKDEConnect(MimeTreeParser::Interface::BodyPart *part, const QString& deviceId) const;
>  

coding style: const QString &dev..

REPOSITORY
  R81 KDE PIM Addons

REVISION DETAIL
  https://phabricator.kde.org/D15467

To: nicolasfella, vkrause, mlaurent
Cc: mlaurent, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180913/e4971145/attachment.html>