D15467: Add open on phone action to Itinerary reservations

Volker Krause noreply at phabricator.kde.org
Thu Sep 13 17:10:34 BST 2018


vkrause added inline comments.

INLINE COMMENTS

> nicolasfella wrote in semanticurlhandler.cpp:500
> openInApp doesn't close either. @vkrause is this intended?

The explicit close looks correct to me, f auto-closes (and thus flushes to disk) when leaving the scope, but technically we use it before that already. Very unlikely, but in theory it seems possible that the other app gets scheduled in before we flushed the content.

Would need to be fixed in the other place too then.

REPOSITORY
  R81 KDE PIM Addons

REVISION DETAIL
  https://phabricator.kde.org/D15467

To: nicolasfella, vkrause, mlaurent
Cc: mlaurent, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180913/e82e9a84/attachment.html>


More information about the kde-pim mailing list