D15916: Rewrite the painting part of agandaitem

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> agendaitem.cpp:1147
> +    
> +    QPoint pointLeftTop(rectWithMargin.x(), rectWithMargin.y());
> +    QPoint pointRightTop(rectWithMargin.x() + rectWithMargin.width(), rectWithMargin.y());

const each time that it's a constant variable please

> agendaitem.cpp:1183
>      if (!frame) {
> -        QLinearGradient gradient(QPointF(r.x(), r.y()), QPointF(r.x(), r.height()));
> +        QBrush brushSolid = QBrush(Qt::SolidPattern);
>  

QBrush brushSolid(Qt::SolidPattern);

REPOSITORY
  R76 PIM: Event Views

REVISION DETAIL
  https://phabricator.kde.org/D15916

To: ognarb, #kde_pim, #kde_pim_junior_jobs, mlaurent, dvratil
Cc: lbeltrame, kde-pim, maciejn, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181003/1f2837ff/attachment.html>