D16245: korgac: Save size and position on dialog hide/close and improve restore

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Minor nitpicks, otherwise looks good.

INLINE COMMENTS

> alarmdialog.cpp:148
> +
> +    QSize initialSize(424, 187);
> +    // split up position and size to be compatible with previous version

`const`

> alarmdialog.cpp:152
> +    QPoint pos = generalConfig.readEntry("Position", QPoint());
> +    if(!pos.isNull()) {
> +        QSize size = generalConfig.readEntry("Size", initialSize);

Coding style: space after `if`

REPOSITORY
  R210 KOrganizer

REVISION DETAIL
  https://phabricator.kde.org/D16245

To: dfries, mlaurent, dvratil
Cc: dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181017/5e743548/attachment.html>