D16377: Using the system palette for drawing the month- and agendaitem.

Laurent Montel noreply at phabricator.kde.org
Tue Oct 23 10:35:48 BST 2018


mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> agenda.cpp:1531
>      //  }
> -
> -    dbp.fillRect(0, 0, cw, ch,
> -                 d->preferences()->agendaGridBackgroundColor());
> +    if (false) {
> +        dbp.fillRect(0, 0, cw, ch,

REmove code if it's always false please

> agenda.cpp:1551
> +        QColor workColor; 
> +        if (false) {
> +            workColor = d->preferences()->workingHoursColor();

same

> agenda.cpp:1615
> +                QColor busyColor;
> +                if (false) {
> +                    busyColor = d->preferences()->viewBgBusyColor();

same

> agenda.cpp:1671
> +        halfHourPen = d->preferences()->agendaGridBackgroundColor().darker(125);
> +    } else {
> +        hourPen = palette().color(QPalette::WindowText).darker(150);

same

> monthscene.cpp:249
>          QColor color;
> -        if (workDays.contains(d)) {
> -            color = mMonthView->preferences()->monthGridWorkHoursBackgroundColor();
> +        if (false) {
> +            if (workDays.contains(d)) {

same

> monthscene.cpp:310
> +    QPen oldPen;
> +    if (false) {
> +        oldPen = mMonthView->preferences()->monthGridBackgroundColor().darker(150);

same

REPOSITORY
  R76 PIM: Event Views

REVISION DETAIL
  https://phabricator.kde.org/D16377

To: ognarb, #kde_pim, #kde_pim_junior_jobs, mlaurent
Cc: mlaurent, dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181023/d578bdda/attachment.html>


More information about the kde-pim mailing list