D16507: Eventviews: simplify/modernize resource color code

Olivier Churlaud noreply at phabricator.kde.org
Tue Oct 30 19:24:35 GMT 2018


ochurlaud added a comment.


  I haven't tried the code but it seems good to me. And way more understandable.
  
  A "Ship it" from me.

INLINE COMMENTS

> prefs.cpp:172
> +        QColor color = rColorsConfig.readEntry(key, mDefaultResourceColor);
> +        //qCDebug(CALENDARVIEW_LOG) << "key:" << key << "value:" << color;
> +        setResourceColor(key, color);

Remove dead code

REPOSITORY
  R76 PIM: Event Views

REVISION DETAIL
  https://phabricator.kde.org/D16507

To: dfaure, dvratil, ochurlaud
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181030/5debfe5c/attachment.html>


More information about the kde-pim mailing list