D16242: korgac: Add an option to not grab keyboard focus when a reminder is displayed

[David Fries]

dfries created this revision.
dfries added a reviewer: mlaurent.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
dfries requested review of this revision.

REVISION SUMMARY
  While it can make it easier to dismiss (if it grabs focus through the
  activateWindow call), it also means if you are typing and a reminder
  comes in it will both get those keystrokes and a space or return will
  dismiss the reminder before you have a chance to ever see what the
  reminder was about, which assumes you are even looking at your screen
  to see the reminder box flash up, if you are typing in a paper you
  might not even know.

TEST PLAN
  Setup two notifications in korganizer one minute apart.
  I the dock window menu test once with "Reminder grabs focus" enabled and once with it disabled.
  Give focus to some other program before the first alarm and second alarm, don't dismiss the reminder box between alarms.
  With "Reminder grabs focus" checked, the Reminders window should get focus on the second reminder, (this is also the behavior before this change).
  With "Reminder grabs focus" unchecked, the Reminders window should not get focus on the second reminder.
  
  Note I'm writing this up for two reminders to avoid the case of window managers which automatically give focus on every new window that pops up.  That's a policy choice on the user/window manager and if this did something to not get focus in that case, this would be going against that policy.

REPOSITORY
  R210 KOrganizer

REVISION DETAIL
  https://phabricator.kde.org/D16242

AFFECTED FILES
  korgac/alarmdialog.cpp
  korgac/alarmdialog.h
  korgac/alarmdockwindow.cpp
  korgac/alarmdockwindow.h

To: dfries, mlaurent
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181016/176009f1/attachment.html>