D16088: Fix color inconsistency for unset categories.

[Denis Kurz]

dkurz created this revision.
dkurz added a reviewer: KDE PIM.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
dkurz requested review of this revision.

REVISION SUMMARY
  KOrganizer's preference dialog states that the color for unset
  categories is only used on the categories-color-only setting. However,
  this is currently not true for Month View, where in each of the mixed
  settings (category-border, resource-fill, or vice versa) the
  unset-category color is also used. With this patch, Month View considers
  the unset-category color only in the category-only setting, just like
  Agenda View.
  
  BUG: 382185
  FIXED-IN: 5.9.3

TEST PLAN
  By testing all four combinations for coloring frame and fill
  a month item, I confirmed Bug 382185: the color for items with no
  categories is used in CategoryOnly as well as in mixed settings (i.e.,
  all settings but ResourceOnly). After applying this patch, I tested them
  again and confirmed that the unset-category color is only used in
  CategoryOnly, while in mixed settings, the resource color is used instead,
  making it consistent to Agenda View and the settings dialog.

REPOSITORY
  R76 PIM: Event Views

BRANCH
  fix-color-inconsistency

REVISION DETAIL
  https://phabricator.kde.org/D16088

AFFECTED FILES
  src/month/monthitem.cpp
  src/month/monthitem.h

To: dkurz, #kde_pim
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181009/1ced35cb/attachment.html>