D16398: Check QtWebEngine version instead of Qt's

[Wolfgang Bauer]

wbauer created this revision.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
wbauer requested review of this revision.

REVISION SUMMARY
  This code depends on the QtWebEngine (not Qt) version, so it should actually check for that.
  Otherwise it breaks if a distribution ships Qt 5.9 LTS together with a newer QtWebEngine, like e.g. openSUSE does.
  
  BUG: 397349

TEST PLAN
  Compiled messagelib with the following combinations:
  
  1. Qt 5.9.4/QtWebEngine 5.9.4
  2. Qt 5.11.2/QtWebEngine 5.11.2
  3. Qt 5.9.4/QtWebEngine 5.10.1
  
  In each case, the intended code path is taken now, i.e. it returns `document.body.scrollTop` in the first case `document.documentElement.scrollTop` for the others.
  
  Also tested it on a real openSUSE Leap 15.0 installation (which comes with Qt 5.9.4 and QtWebEngine 5.10.1), PgUp/PgDown works fine now, it only worked once before.

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D16398

AFFECTED FILES
  webengineviewer/src/webenginescript.cpp

To: wbauer
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181024/c178aea1/attachment.html>