D16089: Factor out coloring from AgendaItem::paintEvent.
Denis Kurz
noreply at phabricator.kde.org
Tue Oct 9 21:26:19 BST 2018
dkurz created this revision.
dkurz added a reviewer: KDE PIM.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
dkurz requested review of this revision.
REVISION SUMMARY
The paintEvent method is already quite long, and calculating colors
inline prohibits a lot of const uses. This commit factors it out into
easily comprehensible small new methods, also making it more obvious
where to look for agenda item coloring for future changes.
TEST PLAN
I tried all color settings for Agenda View and could not
find different behavior with or without patch -- just as expected, as
is a refactoring patch
REPOSITORY
R76 PIM: Event Views
BRANCH
agenda-view-color-style-changes
REVISION DETAIL
https://phabricator.kde.org/D16089
AFFECTED FILES
src/agenda/agendaitem.cpp
src/agenda/agendaitem.h
To: dkurz, #kde_pim
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181009/8ff5bfae/attachment.html>
More information about the kde-pim
mailing list