D16114: Fix keyboard editting of start/end times of VTODOs

[Denis Kurz]

dkurz added a comment.


  In D16114#340904 <https://phabricator.kde.org/D16114#340904>, @winterz wrote:
  
  >   void KTimeComboBox::timeChanged (const QTime & time) [signal]
  >       Signal if the time has been changed either manually by the user or programatically.
  >   
  >   void KTimeComboBox::timeEdited (const QTime & time) [signal]
  >       Signal if the time is being manually edited by the user.
  >   
  >
  > to me that reads as if timeEdited isn't needed if you are using timeChanged.  but .. heck, what do I know?
  
  
  That's exactly what caused the bug I mentioned: timeChanged only fires for changes via mouse and up/down arrow. The function that sets up signal-slot connections for VEVENTs instead of VTODOs even has comments that point out this problem (see line 552).

REPOSITORY
  R78 PIM: Incidence Editor

BRANCH
  fix-todo-kb-editting

REVISION DETAIL
  https://phabricator.kde.org/D16114

To: dkurz, #kde_pim, winterz
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181010/15c4badf/attachment.html>