D15997: Make KPimGAPI optional
Pino Toscano
noreply at phabricator.kde.org
Sun Oct 7 06:37:13 BST 2018
pino created this revision.
pino added a reviewer: dvratil.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
pino requested review of this revision.
REVISION SUMMARY
The smtp plugin requires KPimGAPI for the XOauth2 authentication method;
OTOH, KPimGAPI requires QtWebEngine, which is not really portable (and
only available on few Linux archs).
Hence, since kmailtransport is a library used also in other components,
make sure it can be built without KPimGAPI:
- make KPimGAPI an optional dependency
- disable the XOauth2 authentication method without KPimGAPI, erroring out in case it is attempted
TEST PLAN
- build kmailtransport without KPimGAPI: works, no dependency
- build kmailtransport with KPimGAPI: works, uses KPimGAPI
REPOSITORY
R84 PIM: KMail Transport
BRANCH
optional-kpimgapi (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15997
AFFECTED FILES
CMakeLists.txt
config-kmailtransport.h.cmake
src/kmailtransport/plugins/smtp/CMakeLists.txt
src/kmailtransport/plugins/smtp/autotests/CMakeLists.txt
src/kmailtransport/plugins/smtp/smtpconfigwidget.cpp
src/kmailtransport/plugins/smtp/smtpjob.cpp
To: pino, dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181007/10c24266/attachment.html>
More information about the kde-pim
mailing list