D16013: Rewrite the painting of an month item

[Denis Kurz]

dkurz added a comment.


  The margin helps to immediately grasp that the event starts/ends on that day, just like the radius. I think there should be a margin iff there is a radius.
  
  In the current code, there is also no border drawn when an event continues in that direction (left for !end, right for !begin). Why did you change that? I think the border on the right side of your event on 21st makes the impression of a gap between the right border of the view and the event. My suggestion:
  
  begin => radius, margin and border on the left side
  not begin => no radius, margin or border on the left side
  
  end => radius, margin and border on the right side
  not end => no radius, margin or border on the right side
  
  For short: Either all radius, margin and border, or none at all, per side
  
  I hope I did not confuse what begin/end items are in the first place.

REPOSITORY
  R76 PIM: Event Views

REVISION DETAIL
  https://phabricator.kde.org/D16013

To: ognarb, #kde_pim_junior_jobs, #kde_pim, mlaurent, dvratil
Cc: dkurz, kde-pim, maciejn, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181008/b0d34715/attachment.html>