D16243: korgac: Add a menu option to always get to the reminder dialog.

Daniel Vrátil noreply at phabricator.kde.org
Tue Oct 16 09:29:23 BST 2018


dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Thanks for the patch! Just a minor nitpick, otherwise it looks good.

INLINE COMMENTS

> koalarmclient.cpp:259
> +
> +void KOAlarmClient::allocateDialog() 
> +{

This is just a nitpick, but would you mind renaming this to `createDialog()` (it's more common terminology in our code than allocate).

REPOSITORY
  R210 KOrganizer

REVISION DETAIL
  https://phabricator.kde.org/D16243

To: dfries, mlaurent, dvratil
Cc: dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181016/437f0875/attachment.html>


More information about the kde-pim mailing list