D16013: Rewrite the painting of an month item

[Denis Kurz]

dkurz added a comment.


  Another thing I just noticed: You use border width 1 unconditionally, when it was 2 unconditionally before.
  
  I think that border width 1 is better if the border does not carry information, so +1 in case of CategoryOnly or ResourceOnly. However, if the border DOES cary information (ResourceInsideCategoryOutside, CategoryInsideResourceOutside), that information might be harder to grasp. I experimented a little bit and found this most useful:
  
  - {Category,Resource}Only => border width 1
  - Otherwise => border width 2
  
  However, we should not change too much in a single commit, so I suggest to leave it at "ft" for now and then improve border width in another Diff. If you still choose to ignore "ft" completely, you should remove the static const that is then unused.

REPOSITORY
  R76 PIM: Event Views

REVISION DETAIL
  https://phabricator.kde.org/D16013

To: ognarb, #kde_pim_junior_jobs, #kde_pim, mlaurent, dvratil
Cc: dkurz, kde-pim, maciejn, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181009/215f7457/attachment.html>