D16246: korgac: For no grab avoid mouse cursor when placing window

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  I don't know if this is a good thing or not - there's still the window decoration and mouse pointer size that you would need to take into account, so just moving the window arbitrary amount of pixels left/right/above/below the cursor may or may not be enough based on user's window decorations theme, cursor size and DPI settings.
  
  Isn't there maybe some option in KWindowSystem that would allow us to tell to the window manager "don't give auto focus to this window at any cost"?
  
  Coding style: space after `if` and `for`, opening curly braces on the same line as the `if`/`for` statement

INLINE COMMENTS

> alarmdialog.cpp:631
>  
> +    bool doGrabFocus = grabFocus();
> +

`const bool`

REPOSITORY
  R210 KOrganizer

REVISION DETAIL
  https://phabricator.kde.org/D16246

To: dfries, mlaurent, dvratil
Cc: dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181016/271576da/attachment.html>